Skip to content

yazi: 25.3.2 -> 25.4.8#397092

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
ddogfoodd:update-yazi
Apr 8, 2025
Merged

yazi: 25.3.2 -> 25.4.8#397092
khaneliman merged 1 commit intoNixOS:masterfrom
ddogfoodd:update-yazi

Conversation

@ddogfoodd
Copy link
Contributor

@ddogfoodd ddogfoodd commented Apr 8, 2025

Changelog: https://github.com/sxyazi/yazi/releases/tag/v25.4.8
Diff: sxyazi/yazi@v25.3.2...v25.4.8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 8, 2025
@khaneliman
Copy link
Contributor

khaneliman commented Apr 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397092

x86_64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

aarch64-linux

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

x86_64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

aarch64-darwin

✅ 2 packages built:
  • yazi
  • yazi-unwrapped

@khaneliman khaneliman merged commit 230bd72 into NixOS:master Apr 8, 2025
24 of 27 checks passed
@uncenter
Copy link
Member

uncenter commented Apr 8, 2025 •
edited
Loading

Shouldn't we add resvg as an optional dep (for the updated SVG previewer) in the wrapped Yazi package here?

nixpkgs/pkgs/by-name/ya/yazi/package.nix

Lines 8 to 19 in c4b98bf

optionalDeps ? [
jq
poppler-utils
_7zz
ffmpeg
fd
ripgrep
fzf
zoxide
imagemagick
chafa
],

Listed under "Packaging" in Yazi's release notes.

SVG preview backend switched from ImageMagick to resvg and implemented as a new svg previewer. sxyazi/yazi#2533, sxyazi/yazi#2581

The related pull request states:

After this PR, Yazi will use resvg instead of ImageMagick as the SVG previewer, which is a new optional dependency.

@khaneliman
Copy link
Contributor

khaneliman commented Apr 8, 2025

Shouldn't we add resvg as an optional dep (for the updated SVG previewer) in the wrapped Yazi package here?

nixpkgs/pkgs/by-name/ya/yazi/package.nix

Lines 8 to 19 in c4b98bf

optionalDeps ? [
jq
poppler-utils
_7zz
ffmpeg
fd
ripgrep
fzf
zoxide
imagemagick
chafa
],

Listed under "Packaging" in Yazi's release notes.

SVG preview backend switched from ImageMagick to resvg and implemented as a new svg previewer. sxyazi/yazi#2533, sxyazi/yazi#2581

The related pull request states:

After this PR, Yazi will use resvg instead of ImageMagick as the SVG previewer, which is a new optional dependency.

Ah, good catch. Want to create a follow up PR ?

@ddogfoodd ddogfoodd deleted the update-yazi branch April 8, 2025 15:36
@ddogfoodd ddogfoodd mentioned this pull request Apr 8, 2025
Closed
13 tasks
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Apr 8, 2025 •
edited
Loading

Sorry, my bad.
Here is a follow up PR: #397166
Thank you @uncenter !

ddogfoodd added a commit to ddogfoodd/nixpkgs that referenced this pull request Apr 8, 2025
@ddogfoodd
yazi: replace optional svg dependency
9f28716 
replace imagemagick with resvg
for reference see:
NixOS#397092 (comment)

yazi: add optional dependency `resvg`
@ddogfoodd ddogfoodd mentioned this pull request Apr 8, 2025
Merged
13 tasks
@uncenter
Copy link
Member

uncenter commented Apr 8, 2025

Thanks @ddogfoodd for the quick fix! @khaneliman I would have preferred to address it in this pull request nevertheless - could we give pull requests updating more complex packages such as Yazi (especially because Yazi frequently ships major and/or breaking changes) a bit more time for reviewing? :D

@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Apr 8, 2025

Thanks @ddogfoodd for the quick fix! @khaneliman I would have preferred to address it in this pull request nevertheless - could we give pull requests updating more complex packages such as Yazi (especially because Yazi frequently ships major and/or breaking changes) a bit more time for reviewing? :D

I agree

@ddogfoodd ddogfoodd mentioned this pull request Apr 9, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaneliman khaneliman khaneliman approved these changes

@matthiasbeyer matthiasbeyer Awaiting requested review from matthiasbeyer

@uncenter uncenter Awaiting requested review from uncenter

@XYenon XYenon Awaiting requested review from XYenon

@eljamm eljamm Awaiting requested review from eljamm

+1 more reviewer

@linsui linsui linsui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddogfoodd @khaneliman @uncenter @linsui